]> git.baikalelectronics.ru Git - kernel.git/commit
drm/rockchip: fix fbdev on non-IOMMU devices
authorJohn Keeping <john@metanate.com>
Thu, 20 Oct 2022 18:12:47 +0000 (19:12 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Sat, 29 Oct 2022 12:40:53 +0000 (14:40 +0200)
commitab78c74cfc5a3caa2bbb7627cb8f3bca40bb5fb0
tree1699fc5d4e8fade5fb704486701fc690afdde94a
parent81e592f86f7afdb76d655e7fbd7803d7b8f985d8
drm/rockchip: fix fbdev on non-IOMMU devices

When switching to the generic fbdev infrastructure, it was missed that
framebuffers were created with the alloc_kmap parameter to
rockchip_gem_create_object() set to true.  The generic infrastructure
calls this via the .dumb_create() driver operation and thus creates a
buffer without an associated kmap.

alloc_kmap only makes a difference on devices without an IOMMU, but when
it is missing rockchip_gem_prime_vmap() fails and the framebuffer cannot
be used.

Detect the case where a buffer is being allocated for the framebuffer
and ensure a kernel mapping is created in this case.

Fixes: 24af7c34b290 ("drm/rockchip: use generic fbdev setup")
Reported-by: Johan Jonker <jbx6244@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: John Keeping <john@metanate.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20221020181248.2497065-1-john@metanate.com
drivers/gpu/drm/rockchip/rockchip_drm_gem.c