]> git.baikalelectronics.ru Git - kernel.git/commit
ARM: 8305/1: DMA: Fix kzalloc flags in __iommu_alloc_buffer()
authorAlexandre Courbot <gnurou@gmail.com>
Thu, 19 Feb 2015 06:29:58 +0000 (07:29 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Fri, 20 Feb 2015 11:14:42 +0000 (11:14 +0000)
commitab64ba3338bf5e13746c663bfba4c98a61c1c51b
tree73eebc552458f9569faa14428d492e963aceb2de
parentff658a02a22f199e9eea9cf9373b3b4f69a4edcb
ARM: 8305/1: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

There doesn't seem to be any valid reason to allocate the pages array
with the same flags as the buffer itself. Doing so can eventually lead
to the following safeguard in mm/slab.c's cache_grow() to be hit:

        if (unlikely(flags & GFP_SLAB_BUG_MASK)) {
                pr_emerg("gfp: %un", flags & GFP_SLAB_BUG_MASK);
                BUG();
        }

This happens when buffers are allocated with __GFP_DMA32 or
__GFP_HIGHMEM.

Fix this by allocating the pages array with GFP_KERNEL to follow what is
done elsewhere in this file. Using GFP_KERNEL in __iommu_alloc_buffer()
is safe because atomic allocations are handled by __iommu_alloc_atomic().

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/mm/dma-mapping.c