]> git.baikalelectronics.ru Git - kernel.git/commit
e100: fix typo in MDI/MDI-X eeprom check in e100_phy_init
authorJohn W. Linville <linville@tuxdriver.com>
Sat, 15 Nov 2014 01:19:53 +0000 (01:19 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 31 Dec 2014 19:55:40 +0000 (11:55 -0800)
commitab61adfafd727bd906d5b928c3129505a21fabd9
tree0c881b452c6b51fff64093a1f1d01c779a7a93f6
parentd99a8d98991281e4c2260eef4a2581939890dca8
e100: fix typo in MDI/MDI-X eeprom check in e100_phy_init

Although it doesn't explicitly say so, commit dead4ec1441633d2 ("e100:
Fix MDIO/MDIO-X") appears to be intended to revert the earlier commit
89a2a7151a9a1113 ("e100: fixed e100 MDI/MDI-X issues").  However,
careful examination reveals that the attempted revert actually
_inverted_ the test for eeprom_mdix_enabled.  That is bound to program
a few PHYs incorrectly...

https://bugzilla.redhat.com/show_bug.cgi?id=1156417

Signed-off-by: "John W. Linville" <linville@tuxdriver.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e100.c