]> git.baikalelectronics.ru Git - kernel.git/commit
dm snapshot: workaround for a false positive lockdep warning
authorMikulas Patocka <mpatocka@redhat.com>
Wed, 18 Sep 2013 23:14:22 +0000 (19:14 -0400)
committerMike Snitzer <snitzer@redhat.com>
Fri, 20 Sep 2013 14:36:34 +0000 (10:36 -0400)
commitab3c1b44634e3e592646e8aa61b90db3b55b4620
tree8579f306b45641432a1f4b7f3f4e73e6d2bb9ce7
parentbbcb9a709df5b1d4449eb31baee0ab1c093f0681
dm snapshot: workaround for a false positive lockdep warning

The kernel reports a lockdep warning if a snapshot is invalidated because
it runs out of space.

The lockdep warning was triggered by commit f6409590e16c4810e61cfae7ac57
("workqueue: Catch more locking problems with flush_work()") in v3.5.

The warning is false positive.  The real cause for the warning is that
the lockdep engine treats different instances of md->lock as a single
lock.

This patch is a workaround - we use flush_workqueue instead of flush_work.
This code path is not performance sensitive (it is called only on
initialization or invalidation), thus it doesn't matter that we flush the
whole workqueue.

The real fix for the problem would be to teach the lockdep engine to treat
different instances of md->lock as separate locks.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Acked-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org # 3.5+
drivers/md/dm-snap-persistent.c