]> git.baikalelectronics.ru Git - kernel.git/commit
s390/qdio: don't release memory in qdio_setup_irq()
authorJulian Wiedmann <jwi@linux.ibm.com>
Wed, 2 May 2018 06:28:34 +0000 (08:28 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Tue, 15 May 2018 05:40:38 +0000 (07:40 +0200)
commitaa9d8e53ba4a2a7e323f05ae6f7dfcf2f2837000
tree35c6161dd9e82d735dfcd6b9bc6f6c2c28eb77eb
parent75fb0e58295041d490b21fea37f8618ab4460af6
s390/qdio: don't release memory in qdio_setup_irq()

Calling qdio_release_memory() on error is just plain wrong. It frees
the main qdio_irq struct, when following code still uses it.

Also, no other error path in qdio_establish() does this. So trust
callers to clean up via qdio_free() if some step of the QDIO
initialization fails.

Fixes: 1086a79cead2 ("[S390] qdio: new qdio driver.")
Cc: <stable@vger.kernel.org> #v2.6.27+
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/cio/qdio_setup.c