]> git.baikalelectronics.ru Git - kernel.git/commit
vmxnet3: use correct flag to indicate LRO feature
authorRonak Doshi <doshir@vmware.com>
Fri, 16 Mar 2018 21:49:19 +0000 (14:49 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Mar 2018 00:03:53 +0000 (20:03 -0400)
commitaa9993712d49c0001b44155a79264099e2c922be
tree7e5d27e94b0c1a5f5591aaf0be68356e5b0927bd
parent3c6a4284411aed518635a1c498ef33fdfd147b33
vmxnet3: use correct flag to indicate LRO feature

'Commit 1520c5c54f0e ("vmxnet3: Changes for vmxnet3 adapter version 2
(fwd)")' introduced a flag "lro" in structure vmxnet3_adapter which is
used to indicate whether LRO is enabled or not. However, the patch
did not set the flag and hence it was never exercised.

So, when LRO is enabled, it resulted in poor TCP performance due to
delayed acks. This issue is seen with packets which are larger than
the mss getting a delayed ack rather than an immediate ack, thus
resulting in high latency.

This patch removes the lro flag and directly uses device features
against NETIF_F_LRO to check if lro is enabled.

Fixes: 1520c5c54f0e ("vmxnet3: Changes for vmxnet3 adapter version 2 (fwd)")
Reported-by: Rachel Lunnon <rachel_lunnon@stormagic.com>
Signed-off-by: Ronak Doshi <doshir@vmware.com>
Acked-by: Shrikrishna Khare <skhare@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vmxnet3/vmxnet3_drv.c
drivers/net/vmxnet3/vmxnet3_int.h