]> git.baikalelectronics.ru Git - kernel.git/commit
sh_eth: avoid PHY being resumed when interface is not up
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Wed, 15 Mar 2023 07:41:15 +0000 (08:41 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Mar 2023 12:33:50 +0000 (13:33 +0100)
commitaa1888aa656d638f0e97322b63de2ebcc61d4ca7
tree025039477d49c397a0ecc3ce0c9577ac3df1bbbb
parentc202e34c2510c75eddf008fc3e0105c7a6c463f4
sh_eth: avoid PHY being resumed when interface is not up

[ Upstream commit 8b667d80115406c3c405668996a6d7334985ce46 ]

SH_ETH doesn't need mdiobus suspend/resume, that's why it sets
'mac_managed_pm'. However, setting it needs to be moved from init to
probe, so mdiobus PM functions will really never be called (e.g. when
the interface is not up yet during suspend/resume).

Fixes: cf2e91979a0a ("net: sh_eth: Fix PHY state warning splat during system resume")
Suggested-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/renesas/sh_eth.c