]> git.baikalelectronics.ru Git - kernel.git/commit
media: vsp1: Fix offset calculation for plane cropping
authorMichael Rodin <mrodin@de.adit-jv.com>
Tue, 23 Nov 2021 11:50:36 +0000 (12:50 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 13 May 2022 09:02:21 +0000 (11:02 +0200)
commita96ddd841cbb7ae7e17691341fa6f4d05d88da73
tree754d9b58666bdb04892942c7c28ba66bea500cef
parent7167f659f7d02c78f6471d0d4a9d38b9ed597bf4
media: vsp1: Fix offset calculation for plane cropping

The vertical subsampling factor is currently not considered in the
offset calculation for plane cropping done in rpf_configure_partition.
This causes a distortion (shift of the color plane) when formats with
the vsub factor larger than 1 are used (e.g. NV12, see
vsp1_video_formats in vsp1_pipe.c). This commit considers vsub factor
for all planes except plane 0 (luminance).

Drop generalization of the offset calculation to reduce the binary size.

Fixes: ac6496a7b3c2 ("[media] v4l: vsp1: Add cropping support")
Signed-off-by: Michael Rodin <mrodin@de.adit-jv.com>
Signed-off-by: LUU HOAI <hoai.luu.ub@renesas.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/renesas/vsp1/vsp1_rpf.c