]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx5e: Use spin_lock_bh for async_icosq_lock
authorMaxim Mikityanskiy <maximmi@mellanox.com>
Thu, 8 Oct 2020 08:34:03 +0000 (11:34 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Thu, 5 Nov 2020 20:17:05 +0000 (12:17 -0800)
commita832f57c1e9628e760af1ccf889649d693e4b7ca
treec2e27d54e28d2071b139ce2e73ba586e7ed3dd8a
parent4cfbdf4fb1df3385ef5817cbae6f7ccff61f82c5
net/mlx5e: Use spin_lock_bh for async_icosq_lock

async_icosq_lock may be taken from softirq and non-softirq contexts. It
requires protection with spin_lock_bh, otherwise a softirq may be
triggered in the middle of the critical section, and it may deadlock if
it tries to take the same lock. This patch fixes such a scenario by
using spin_lock_bh to disable softirqs on that CPU while inside the
critical section.

Fixes: ec91b3118e45 ("net/mlx5e: Turn XSK ICOSQ into a general asynchronous one")
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.c
drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c