]> git.baikalelectronics.ru Git - kernel.git/commit
fsnotify: fix sb_connectors leak
authorAmir Goldstein <amir73il@gmail.com>
Thu, 9 Sep 2021 11:56:34 +0000 (14:56 +0300)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 10 Sep 2021 16:46:48 +0000 (09:46 -0700)
commita801f22c18896c3adde660b7834b5740f90193f2
tree5bd2044ab9bcf43b128ef914971358ce67adac42
parentdea32832bec7e62e9410231fb40762e99cfb0c4b
fsnotify: fix sb_connectors leak

Fix a leak in s_fsnotify_connectors counter in case of a race between
concurrent add of new fsnotify mark to an object.

The task that lost the race fails to drop the counter before freeing
the unused connector.

Following umount() hangs in fsnotify_sb_delete()/wait_var_event(),
because s_fsnotify_connectors never drops to zero.

Fixes: ee315796aa6a ("fsnotify: count all objects with attached connectors")
Reported-by: Murphy Zhou <jencce.kernel@gmail.com>
Link: https://lore.kernel.org/linux-fsdevel/20210907063338.ycaw6wvhzrfsfdlp@xzhoux.usersys.redhat.com/
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/notify/mark.c