]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "firmware: add sanity check on shutdown/suspend"
authorLinus Torvalds <torvalds@linux-foundation.org>
Mon, 11 Sep 2017 04:19:06 +0000 (21:19 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 11 Sep 2017 04:19:06 +0000 (21:19 -0700)
commita7de502314c168adbf8743005312ac86bd486260
tree3347b090b27c27082414070a9cbf08a7bb75cbc6
parent533c7f9269315ecc1d8ad8550ab7b70bdfbc4cca
Revert "firmware: add sanity check on shutdown/suspend"

This reverts commit 602dbf69ec08b1b91f1f2db5e34f12c897e85a2e.

It causes random failures of firmware loading at resume time (well,
random for me, it seems to be more reliable for others) because the
firmware disabling is not actually synchronous with any particular
resume event, and at least the btusb driver that uses a workqueue to
load the firmware at resume seems to occasionally hit the "firmware
loading is disabled" logic because the firmware loader hasn't gotten the
resume event yet.

Some kind of sanity check for not trying to load firmware when it's not
possible might be a good thing, but this commit was not it.

Greg seems to have silently suffered the same issue, and pointed to the
likely culprit, and Gabriel C verified the revert fixed it for him too.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Pointed-at-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tested-by: Gabriel C <nix.or.die@gmail.com>
Cc: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Documentation/driver-api/firmware/request_firmware.rst
drivers/base/firmware_class.c