]> git.baikalelectronics.ru Git - kernel.git/commit
virtio_console: free buffers after reset
authorMichael S. Tsirkin <mst@redhat.com>
Fri, 20 Apr 2018 17:24:23 +0000 (20:24 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 25 Apr 2018 17:41:16 +0000 (20:41 +0300)
commita7a69ec0d8e4a58be7db88d33cbfa2912807bb2b
tree01374a64530550c86ddf3bc55b55c9366dbdb62d
parent24a7e4d20783c0514850f24a5c41ede46ab058f0
virtio_console: free buffers after reset

Console driver is out of spec. The spec says:
A driver MUST NOT decrement the available idx on a live
virtqueue (ie. there is no way to “unexpose” buffers).
and it does exactly that by trying to detach unused buffers
without doing a device reset first.

Defer detaching the buffers until device unplug.

Of course this means we might get an interrupt for
a vq without an attached port now. Handle that by
discarding the consumed buffer.

Reported-by: Tiwei Bie <tiwei.bie@intel.com>
Fixes: b3258ff1d6 ("virtio: Decrement avail idx on buffer detach")
Cc: stable@vger.kernel.org
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/char/virtio_console.c