]> git.baikalelectronics.ru Git - kernel.git/commit
KEYS: Revert one application of "Fix unreachable code" patch
authorDavid Howells <dhowells@redhat.com>
Thu, 21 Feb 2013 12:00:25 +0000 (12:00 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 21 Feb 2013 15:56:25 +0000 (07:56 -0800)
commita737f0072a02a5975aa1538b9dc69da51f5db06c
treeba144f62734e9d89ed515466972c318de561ccb2
parentc5a8fb0e61d6f30c554cfd39594939b9858146d6
KEYS: Revert one application of "Fix unreachable code" patch

A patch to fix some unreachable code in search_my_process_keyrings() got
applied twice by two different routes upstream as commits 26c4a2feb393
and d9fe9c32782e (both "fix unreachable code").

Unfortunately, the second application removed something it shouldn't
have and this wasn't detected by GIT.  This is due to the patch not
having sufficient lines of context to distinguish the two places of
application.

The effect of this is relatively minor: inside the kernel, the keyring
search routines may search multiple keyrings and then prioritise the
errors if no keys or negative keys are found in any of them.  With the
extra deletion, the presence of a negative key in the thread keyring
(causing ENOKEY) is incorrectly overridden by an error searching the
process keyring.

So revert the second application of the patch.

Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
security/keys/process_keys.c