]> git.baikalelectronics.ru Git - kernel.git/commit
blk-mq: bitmap tag: fix races in bt_get() function
authorAlexander Gordeev <agordeev@redhat.com>
Tue, 17 Jun 2014 20:37:23 +0000 (22:37 +0200)
committerJens Axboe <axboe@fb.com>
Wed, 18 Jun 2014 05:13:08 +0000 (22:13 -0700)
commita73017eb7b62d775995c9614325742c09cd9f09f
treeda76443281fb15c54d56400b25ff9279e0b9e33e
parent5e6a63ca6f7272104af336c431772c6b309fbc95
blk-mq: bitmap tag: fix races in bt_get() function

This update fixes few issues in bt_get() function:

- list_empty(&wait.task_list) check is not protected;

- was_empty check is always true which results in *every* thread
  entering the loop resets bt_wait_state::wait_cnt counter rather
  than every bt->wake_cnt'th thread;

- 'bt_wait_state::wait_cnt' counter update is redundant, since
  it also gets reset in bt_clear_tag() function;

Cc: Christoph Hellwig <hch@infradead.org>
Cc: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/blk-mq-tag.c