]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "Staging: zram: work around oops due to startup ordering snafu"
authorNitin Gupta <ngupta@vflare.org>
Thu, 30 Dec 2010 09:07:58 +0000 (04:07 -0500)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 30 Dec 2010 20:07:22 +0000 (12:07 -0800)
commita727c4d4479a9261257a701d110a520745b4bcbb
tree8daebe3e685971ea0db8ddc0dcda96a1781019b2
parent49ce9e5327e40fddeadfefa1f1a75af1eec2e596
Revert "Staging: zram: work around oops due to startup ordering snafu"

This reverts commit a5426af719d536a41e90b8da9964ef66f273dadd because it
was never appropriate for mainline.

Do not check for init flag before starting I/O - zram module is unusable
without this fix.

The oops mentioned in the reverted commit message was actually a problem
only with the zram version as present in project's own repository where
we allocate struct zram_stats_cpu upon device initialization.  OTOH, In
mainline/staging version of zram, we allocate struct stats upfront, so
this oops cannot happen in mainline version.

Checking for init_done flag in zram_make_request() results in a *no-op*
for any I/O operation since we simply always return success.  This flag
is actually set when the first write occurs on a zram disk which
triggers its initialization.

Bug report: https://bugzilla.kernel.org/show_bug.cgi?id=25722

Reported-by: Dennis Jansen <dennis.jansen@web.de>
Signed-off-by: Nitin Gupta <ngupta@vflare.org>
Cc: Anton Blanchard <anton@samba.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/staging/zram/zram_drv.c