]> git.baikalelectronics.ru Git - kernel.git/commit
btrfs: fix balance range usage filters in 4.4-rc
authorHolger Hoffstätte <holger.hoffstaette@googlemail.com>
Tue, 17 Nov 2015 11:29:32 +0000 (12:29 +0100)
committerChris Mason <clm@fb.com>
Wed, 25 Nov 2015 13:27:33 +0000 (05:27 -0800)
commita7249f6d6a887c3c2c8c8799ee5b36a822850d3c
treecde1595891c3167cd7da675cd8519df80ac7016e
parentedab729823ae88a67ddf4eb7948719e51ec386ae
btrfs: fix balance range usage filters in 4.4-rc

There's a regression in 4.4-rc since commit badf80a5c31b
(btrfs: extend balance filter usage to take minimum and maximum) in that
existing (non-ranged) balance with -dusage=x no longer works; all chunks
are skipped.

After staring at the code for a while and wondering why a non-ranged
balance would even need min and max thresholds (..which then were not
set correctly, leading to the bug) I realized that the only problem
was the fact that the filter functions were named wrong, thanks to
patching copypasta. Simply renaming both functions lets the existing
btrfs-progs call balance with -dusage=x and now the non-ranged filter
function is invoked, properly using only a single chunk limit.

Signed-off-by: Holger Hoffstätte <holger.hoffstaette@googlemail.com>
Fixes: badf80a5c31b ("btrfs: extend balance filter usage to take minimum and maximum")
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>
fs/btrfs/volumes.c