]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: hda: Fix potential access overflow in beep helper
authorTakashi Iwai <tiwai@suse.de>
Tue, 7 Apr 2020 08:44:01 +0000 (10:44 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 7 Apr 2020 14:42:29 +0000 (16:42 +0200)
commita6ab2fdf384eea97064757592b1e341f4da7a78e
tree47c181d53c04caebc3e5ba60149f6162954b1158
parent8668f22f2be2a5cc4b82ccdc77ecc0d6bb7fb422
ALSA: hda: Fix potential access overflow in beep helper

The beep control helper function blindly stores the values in two
stereo channels no matter whether the actual control is mono or
stereo.  This is practically harmless, but it annoys the recently
introduced sanity check, resulting in an error when the checker is
enabled.

This patch corrects the behavior to store only on the defined array
member.

Fixes: a2366a6ffb32 ("ALSA: hda - Move beep helper functions to hda_beep.c")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207139
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200407084402.25589-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_beep.c