]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: mv88e6xxx: Unforce speed & duplex in mac_link_down()
authorMarek Behún <kabel@kernel.org>
Sat, 11 Dec 2021 22:51:41 +0000 (23:51 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Dec 2021 14:40:29 +0000 (14:40 +0000)
commita662940d2e78a9c8bf81efa046357e88ef59a6da
treeec49fd7c99f0dba8c6c53db933cc778d5412497f
parent0dc70d5921727135c5e8805b15afa261da9bbe94
net: dsa: mv88e6xxx: Unforce speed & duplex in mac_link_down()

Commit 8764dc108c92 ("net: dsa: mv88e6xxx: configure interface settings
in mac_config") removed forcing of speed and duplex from
mv88e6xxx_mac_config(), where the link is forced down, and left it only
in mv88e6xxx_mac_link_up(), by which time link is unforced.

It seems that (at least on 88E6190) when changing cmode to 2500base-x,
if the link is not forced down, but the speed or duplex are still
forced, the forcing of new settings for speed & duplex doesn't take in
mv88e6xxx_mac_link_up().

Fix this by unforcing speed & duplex in mv88e6xxx_mac_link_down().

Fixes: 8764dc108c92 ("net: dsa: mv88e6xxx: configure interface settings in mac_config")
Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/chip.c