]> git.baikalelectronics.ru Git - kernel.git/commit
net: lan966x: check devm_of_phy_get() for -EDEFER_PROBE
authorMichael Walle <michael@walle.cc>
Wed, 25 May 2022 23:12:39 +0000 (01:12 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 27 May 2022 03:45:29 +0000 (20:45 -0700)
commita64ed2bc05631de85b295a16fee8be0a52779293
treeb16ea24c177cd635c1a628a9c2923d37e9e9914e
parent24e8ef8f2d92440f5e73aa9603ab0e34d12f7abb
net: lan966x: check devm_of_phy_get() for -EDEFER_PROBE

At the moment, if devm_of_phy_get() returns an error the serdes
simply isn't set. While it is bad to ignore an error in general, there
is a particular bug that network isn't working if the serdes driver is
compiled as a module. In that case, devm_of_phy_get() returns
-EDEFER_PROBE and the error is silently ignored.

The serdes is optional, it is not there if the port is using RGMII, in
which case devm_of_phy_get() returns -ENODEV. Rearrange the error
handling so that -ENODEV will be handled but other error codes will
abort the probing.

Fixes: 055718c1aaaf ("net: lan966x: add port module support")
Signed-off-by: Michael Walle <michael@walle.cc>
Link: https://lore.kernel.org/r/20220525231239.1307298-1-michael@walle.cc
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/lan966x/lan966x_main.c