]> git.baikalelectronics.ru Git - kernel.git/commit
ARM: 9233/1: stacktrace: Skip frame pointer boundary check for call_with_stack()
authorLi Huafei <lihuafei1@huawei.com>
Fri, 26 Aug 2022 08:06:22 +0000 (09:06 +0100)
committerRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 4 Oct 2022 10:09:47 +0000 (11:09 +0100)
commita61e031de276cbe1e76dbf051b054f3041aee4ad
tree459e56c09936983f81f6f3f029dab44a4820d791
parent5047a32b062611790bfbfdb29b019745882c5a1f
ARM: 9233/1: stacktrace: Skip frame pointer boundary check for call_with_stack()

When using the frame pointer unwinder, it was found that the stack trace
output of stack_trace_save() is incomplete if the stack contains
call_with_stack():

 [0x7f00002c] dump_stack_task+0x2c/0x90 [hrtimer]
 [0x7f0000a0] hrtimer_hander+0x10/0x18 [hrtimer]
 [0x801a67f0] __hrtimer_run_queues+0x1b0/0x3b4
 [0x801a7350] hrtimer_run_queues+0xc4/0xd8
 [0x801a597c] update_process_times+0x3c/0x88
 [0x801b5a98] tick_periodic+0x50/0xd8
 [0x801b5bf4] tick_handle_periodic+0x24/0x84
 [0x8010ffc4] twd_handler+0x38/0x48
 [0x8017d220] handle_percpu_devid_irq+0xa8/0x244
 [0x80176e9c] generic_handle_domain_irq+0x2c/0x3c
 [0x8052e3a8] gic_handle_irq+0x7c/0x90
 [0x808ab15c] generic_handle_arch_irq+0x60/0x80
 [0x8051191c] call_with_stack+0x1c/0x20

For the frame pointer unwinder, unwind_frame() checks stackframe::fp by
stackframe::sp. Since call_with_stack() switches the SP from one stack
to another, stackframe::fp and stackframe: :sp will point to different
stacks, so we can no longer check stackframe::fp by stackframe::sp. Skip
checking stackframe::fp at this point to avoid this problem.

Signed-off-by: Li Huafei <lihuafei1@huawei.com>
Reviewed-by: Linus Waleij <linus.walleij@linaro.org>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
arch/arm/kernel/stacktrace.c
arch/arm/lib/call_with_stack.S