]> git.baikalelectronics.ru Git - kernel.git/commit
pinctrl-aspeed-g5: Never set SCU90[6]
authorAndrew Jeffery <andrew@aj.id.au>
Wed, 2 Nov 2016 14:37:56 +0000 (01:07 +1030)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 7 Nov 2016 09:31:33 +0000 (10:31 +0100)
commita6055e0e1a89b2f42c3009f211d3953555b72613
tree6c59b8286b7b23a5841559c6d97ab1c68db43780
parent365c95e45d31484b6fed10cfca87f012ac45e84a
pinctrl-aspeed-g5: Never set SCU90[6]

If a pin depending on bit 6 in SCU90 is requested for GPIO, the export
will succeed but changes to the GPIO's value will not be accepted by the
hardware. This is because the pinmux driver has misconfigured the SCU by
writing 1 to the reserved bit.

The description of SCU90[6] from the datasheet is 'Reserved, must keep
at value ”0”'. The fix is to switch pinmux from the bit-flipping macro
to explicitly configuring the .enable and .disable values to zero.

The patch has been tested on an AST2500 EVB.

Fixes: 4666b756f753 (pinctrl: Add pinctrl-aspeed-g5 driver)
Reported-by: Uma Yadlapati <yadlapat@us.ibm.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c