]> git.baikalelectronics.ru Git - kernel.git/commit
net/wan: fix a double free in x25_asy_open_tty()
authorCong Wang <xiyou.wangcong@gmail.com>
Sat, 29 Dec 2018 21:56:37 +0000 (13:56 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 31 Dec 2018 04:22:48 +0000 (20:22 -0800)
commita5a708cce2134a72f7f405ac43f04d376ec521b5
tree7fc6a09d7ea3da996a921d319f2d7ae22a321039
parent404558166e937e2b97263714b83286d81a2f535f
net/wan: fix a double free in x25_asy_open_tty()

When x25_asy_open() fails, it already cleans up by itself,
so its caller doesn't need to free the memory again.

It seems we still have to call x25_asy_free() to clear the SLF_INUSE
bit, so just set these pointers to NULL after kfree().

Reported-and-tested-by: syzbot+5e5e969e525129229052@syzkaller.appspotmail.com
Fixes: 8870ccb7938a ("x25_asy: Free x25_asy on x25_asy_open() failure.")
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/x25_asy.c