]> git.baikalelectronics.ru Git - kernel.git/commit
dm: don't use bio_trim() afterall
authorMike Snitzer <snitzer@redhat.com>
Tue, 5 Feb 2019 22:07:58 +0000 (17:07 -0500)
committerMike Snitzer <snitzer@redhat.com>
Wed, 6 Feb 2019 22:24:37 +0000 (17:24 -0500)
commita54a75a433e64fa3ea5efb075c8b569a713f2924
treec71162dd2bd0cfc5e80d5e2b1ca3d72721f4ff48
parent43f71833078bdf9e43d15d6553d19e7fac3575c7
dm: don't use bio_trim() afterall

bio_trim() has an early return, which makes it _not_ idempotent, if the
offset is 0 and the bio's bi_size already matches the requested size.
Prior to DM, all users of bio_trim() were fine with this.  But DM has
exposed the fact that bio_trim()'s early return is incompatible with a
cloned bio whose integrity payload must be trimmed via
bio_integrity_trim().

Fix this by reverting DM back to doing the equivalent of bio_trim() but
in an idempotent manner (so bio_integrity_trim is always performed).

Follow-on work is needed to assess what benefit bio_trim()'s early
return is providing to its existing callers.

Reported-by: Milan Broz <gmazyland@gmail.com>
Fixes: de3f365a06417 ("dm: fix clone_bio() to trigger blk_recount_segments()")
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm.c