]> git.baikalelectronics.ru Git - kernel.git/commit
regulator: slg51000: use devm_gpiod_get_optional() in probe
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 4 Sep 2019 21:42:00 +0000 (14:42 -0700)
committerMark Brown <broonie@kernel.org>
Mon, 9 Sep 2019 09:58:15 +0000 (10:58 +0100)
commita545b28e391ed48b7ba215e0890a1c535865f1aa
tree5d3e5ff2277b873387de2bab41addc78f7273050
parent0d18c46ce637efac20dc822cd761e3529bb16324
regulator: slg51000: use devm_gpiod_get_optional() in probe

The CS GPIO line is clearly optional GPIO (and marked as such in the
binding document) and we should handle it accordingly. The current code
treats all errors as meaning that there is no GPIO defined, which is
wrong, as it does not handle deferrals raised by the underlying code
properly, nor does it recognize non-existing GPIO from any other
initialization error.

As far as I can see the only reason the driver, unlike all others,
is using OF-specific devm_gpiod_get_from_of_node() so that it can
assign a custom label to the selected GPIO line. Given that noone else
needs that, it should not be doing that either.

Let's switch to using more appropriate devm_gpiod_get_optional().

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Link: https://lore.kernel.org/r/20190904214200.GA66118@dtor-ws
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/slg51000-regulator.c