]> git.baikalelectronics.ru Git - kernel.git/commit
net: phy: icplus: call phy_restore_page() when phy_select_page() fails
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 19 Feb 2021 10:10:44 +0000 (13:10 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 23 Feb 2021 02:47:48 +0000 (18:47 -0800)
commita4a4501bfb8dced147b1160c7290fe6fa36776e5
tree7bcc1d8d4a82e1760b06df5fbaca216be0c2bc36
parent238025482715d411b10d79a5a5b3435af79d67ca
net: phy: icplus: call phy_restore_page() when phy_select_page() fails

The comments to phy_select_page() say that "phy_restore_page() must
always be called after this, irrespective of success or failure of this
call."  If we don't call phy_restore_page() then we are still holding
the phy_lock_mdio_bus() so it eventually leads to a dead lock.

Fixes: 1d66e52f4326 ("net: phy: icplus: add MDI/MDIX support for IP101A/G")
Fixes: 408dc7d0ae78 ("net: phy: icplus: fix paged register access")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michael Walle <michael@walle.cc>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/YC+OpFGsDPXPnXM5@mwanda
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/icplus.c