]> git.baikalelectronics.ru Git - kernel.git/commit
ethtool: allow non-netadmin to query settings
authorstephen hemminger <shemminger@vyatta.com>
Mon, 23 Aug 2010 10:24:18 +0000 (10:24 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Aug 2010 03:43:16 +0000 (20:43 -0700)
commita48fc4af5c29d102d4b841135bb65679ca39c974
tree354e79b15b101a2ace627ce08779e4ef40c1e477
parent003f616638cc13f9fbf45a5c12e5f35f3d45d0ee
ethtool: allow non-netadmin to query settings

The SNMP daemon uses ethtool to determine the speed of
network interfaces. This fails on Debian (and probably elsewhere)
because for security SNMP daemon runs as non-root user (snmp).

Note: A similar patch was rejected previously because of a concern about
the possibility that on some hardware querying the ethtool settings
requires access to the PHY and could slow the machine down.  But the
security risk of requiring SNMP daemon (and related services)
to run as root far out weighs the risk of denial-of-service.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/ethtool.c