]> git.baikalelectronics.ru Git - kernel.git/commit
firmware_loader: enable XZ by default if compressed support is enabled
authorLinus Torvalds <torvalds@linux-foundation.org>
Fri, 3 Jun 2022 22:46:03 +0000 (15:46 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 3 Jun 2022 22:46:03 +0000 (15:46 -0700)
commita38599aefe4d001ee286a2cc6ec0c6a850e0bd28
tree61c13f39f96b1141d7010941d6dcbe775b45b45a
parent381e4f6aa9ba3f194651acbb0bee0627e530af6d
firmware_loader: enable XZ by default if compressed support is enabled

Commit 4e9974ca6046 ("firmware: Add the support for ZSTD-compressed
firmware files") added support for ZSTD compression, but in the process
also made the previously default XZ compression a config option.

That means that anybody who upgrades their kernel and does a

    make oldconfig

to update their configuration, will end up without the XZ compression
that the configuration used to have.

Add the 'default y' to make sure this doesn't happen.

The whole compression question should probably be improved upon, since
it is now possible to "enable" compression in the kernel config but not
enable any actual compression algorithm, which makes it all very
useless.  It makes no sense to ask Kconfig questions that enable
situations that are nonsensical like that.

This at least fixes the immediate problem of a kernel update resulting
in a nonbootable machine because of a missed option.

Fixes: 4e9974ca6046 ("firmware: Add the support for ZSTD-compressed firmware files")
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/base/firmware_loader/Kconfig