]> git.baikalelectronics.ru Git - kernel.git/commit
tcp: ulp: fix possible crash in tcp_diag_get_aux_size()
authorEric Dumazet <edumazet@google.com>
Thu, 5 Sep 2019 20:20:41 +0000 (13:20 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Sep 2019 15:32:28 +0000 (17:32 +0200)
commita21f40c915bb12c3266da789ea073dd633f3930b
tree32d0dcfaa1ed927c724a286773a3e47317f9f780
parentf2f5cf2c91d0753cc94e8aacc7b0e6a51dead7fb
tcp: ulp: fix possible crash in tcp_diag_get_aux_size()

tcp_diag_get_aux_size() can be called with sockets in any state.

icsk_ulp_ops is only present for full sockets.

For SYN_RECV or TIME_WAIT ones we would access garbage.

Fixes: 18dfa897d1ac ("tcp: ulp: add functions to dump ulp-specific information")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Luke Hsiao <lukehsiao@google.com>
Reported-by: Neal Cardwell <ncardwell@google.com>
Cc: Davide Caratti <dcaratti@redhat.com>
Acked-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_diag.c