]> git.baikalelectronics.ru Git - kernel.git/commit
bus: imx-weim: fix branch condition evaluates to a garbage value
authorIvan Bornyakov <i.bornyakov@metrotek.ru>
Mon, 6 Mar 2023 13:25:26 +0000 (16:25 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Apr 2023 09:16:42 +0000 (11:16 +0200)
commita1f322d448ee2fbe39c36bbfc82e10d94a8b45cc
tree6fe019b630f509af5a4c9477ddd0e9a5f4782d2a
parentd5d6304431f2eb7c3860273d7e4bff12bc9df47b
bus: imx-weim: fix branch condition evaluates to a garbage value

[ Upstream commit 1adab2922c58e7ff4fa9f0b43695079402cce876 ]

If bus type is other than imx50_weim_devtype and have no child devices,
variable 'ret' in function weim_parse_dt() will not be initialized, but
will be used as branch condition and return value. Fix this by
initializing 'ret' with 0.

This was discovered with help of clang-analyzer, but the situation is
quite possible in real life.

Fixes: 81c9746754a6 ("bus: imx-weim: improve error handling upon child probe-failure")
Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: stable@vger.kernel.org
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/bus/imx-weim.c