]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: SOF: sof-audio: prepare_widgets: Check swidget for NULL on sink failure
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Fri, 20 Jan 2023 10:21:25 +0000 (12:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Feb 2023 10:28:26 +0000 (11:28 +0100)
commita1f297d67b2705d4209dbdb56660637dd72a5faf
tree0496d168a1a8ada2856660b1037221e88e7ed3a7
parentaf42680c69cc1e4156eddc9162205df1cd3ef4c4
ASoC: SOF: sof-audio: prepare_widgets: Check swidget for NULL on sink failure

commit b2c2914e7fe73571127853fd2087ffe9e2b2584e upstream.

If the swidget is NULL we skip the preparing of the widget and jump to
handle the sink path of the widget.
If the prepare fails in this case we would undo the prepare but the swidget
is NULL (we skipped the prepare for the widget).

To avoid NULL pointer dereference in this case we must check swidget
against NULL pointer once again.

Fixes: 7e1ca5de0401 ("ASoC: SOF: sof-audio: skip prepare/unprepare if swidget is NULL")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230120102125.30653-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/sof/sof-audio.c