]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "Input: synaptics-rmi4 - don't increment rmiaddr for SMBus transfers"
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 17 Jan 2020 04:12:27 +0000 (20:12 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 17 Jan 2020 04:22:55 +0000 (20:22 -0800)
commita1c459e4ff4e59829cc47f90028fc2ecbb14f6cc
tree7489f5d44952f9a499515df7259c61b35b5600f3
parent49a321f6b32e23ec68f29c9669ec13b516ff1d86
Revert "Input: synaptics-rmi4 - don't increment rmiaddr for SMBus transfers"

This reverts commit ee64fe37ff6c4cbdb504ecce32dc9cddeb6e52fa.

This causes problems (drifting cursor) with at least the F11 function that
reads more than 32 bytes.

The real issue is in the F54 driver, and so this should be fixed there, and
not in rmi_smbus.c.

So first revert this bad commit, then fix the real problem in F54 in another
patch.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: Timo Kaufmann <timokau@zoho.com>
Fixes: ee64fe37ff6c ("Input: synaptics-rmi4 - don't increment rmiaddr for SMBus transfers")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20200115124819.3191024-2-hverkuil-cisco@xs4all.nl
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_smbus.c