]> git.baikalelectronics.ru Git - kernel.git/commit
net/smc: check for missing nlattrs in SMC_PNETID messages
authorEric Biggers <ebiggers@google.com>
Mon, 14 May 2018 00:01:30 +0000 (17:01 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 May 2018 20:40:45 +0000 (16:40 -0400)
commita1b7b00fc3f7ed44bf8aff00f295028168c5d12e
tree533f8add47270500c196ce5241e8d578283a4dc6
parent71c6ce227d743d2f19fa3c706a4c46af5f6a4997
net/smc: check for missing nlattrs in SMC_PNETID messages

It's possible to crash the kernel in several different ways by sending
messages to the SMC_PNETID generic netlink family that are missing the
expected attributes:

- Missing SMC_PNETID_NAME => null pointer dereference when comparing
  names.
- Missing SMC_PNETID_ETHNAME => null pointer dereference accessing
  smc_pnetentry::ndev.
- Missing SMC_PNETID_IBNAME => null pointer dereference accessing
  smc_pnetentry::smcibdev.
- Missing SMC_PNETID_IBPORT => out of bounds array access to
  smc_ib_device::pattr[-1].

Fix it by validating that all expected attributes are present and that
SMC_PNETID_IBPORT is nonzero.

Reported-by: syzbot+5cd61039dc9b8bfa6e47@syzkaller.appspotmail.com
Fixes: a540a3af8976 ("smc: establish pnet table management")
Cc: <stable@vger.kernel.org> # v4.11+
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/smc/smc_pnet.c