]> git.baikalelectronics.ru Git - kernel.git/commit
drm: xlnx: zynqmp_dpsub: Call pm_runtime_get_sync before setting pixel clock
authorQuanyang Wang <quanyang.wang@windriver.com>
Wed, 10 Mar 2021 04:59:45 +0000 (12:59 +0800)
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Sun, 8 Aug 2021 23:28:04 +0000 (02:28 +0300)
commita19effb6dbe5bd1be77a6d68eba04dba8993ffeb
treee817523407ed95a2459440689d6d955af2877513
parent49f7844b08844ac7029f997702099c552566262b
drm: xlnx: zynqmp_dpsub: Call pm_runtime_get_sync before setting pixel clock

The Runtime PM subsystem will force the device "fd4a0000.zynqmp-display"
to enter suspend state while booting if the following conditions are met:
- the usage counter is zero (pm_runtime_get_sync hasn't been called yet)
- no 'active' children (no zynqmp-dp-snd-xx node under dpsub node)
- no other device in the same power domain (dpdma node has no
"power-domains = <&zynqmp_firmware PD_DP>" property)

So there is a scenario as below:
1) DP device enters suspend state   <- call zynqmp_gpd_power_off
2) zynqmp_disp_crtc_setup_clock     <- configurate register VPLL_FRAC_CFG
3) pm_runtime_get_sync     <- call zynqmp_gpd_power_on and clear previous
       VPLL_FRAC_CFG configuration
4) clk_prepare_enable(disp->pclk)   <- enable failed since VPLL_FRAC_CFG
       configuration is corrupted

From above, we can see that pm_runtime_get_sync may clear register
VPLL_FRAC_CFG configuration and result the failure of clk enabling.
Putting pm_runtime_get_sync at the very beginning of the function
zynqmp_disp_crtc_atomic_enable can resolve this issue.

Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/gpu/drm/xlnx/zynqmp_disp.c