]> git.baikalelectronics.ru Git - kernel.git/commit
net: sparx5: Fix return type of sparx5_port_xmit_impl
authorNathan Huckleberry <nhuck@google.com>
Thu, 29 Sep 2022 18:19:47 +0000 (11:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Oct 2022 07:07:40 +0000 (08:07 +0100)
commita0d60b4cd3080f2416ab24d3f9d837320add6914
tree9bf02d411a381ec63bbea33922ada7bd06a7b9b3
parenta1d98355d6d40b6e9e6376a22028b5f5562242bb
net: sparx5: Fix return type of sparx5_port_xmit_impl

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of sparx5_port_xmit_impl should be changed from int to
netdev_tx_t.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/sparx5/sparx5_main.h
drivers/net/ethernet/microchip/sparx5/sparx5_packet.c