]> git.baikalelectronics.ru Git - kernel.git/commit
HID: wacom: Simplify 'wacom_pl_irq'
authorJason Gerecke <killertofu@gmail.com>
Mon, 3 Aug 2015 17:18:10 +0000 (10:18 -0700)
committerJiri Kosina <jkosina@suse.cz>
Mon, 10 Aug 2015 23:03:48 +0000 (01:03 +0200)
commita0c95261e0dc25a76cb1f04cc5ee8853a5ccefc0
treec308e3921cde5ef2c45048358cc479c969fd3bc1
parentd833856eeba38cb179601385ebe218d2e4e46638
HID: wacom: Simplify 'wacom_pl_irq'

Unlike other IRQ functions, 'wacom_pl_irq' uses the second element of
the 'tool' array to store information about its single pen. This makes
the function more difficult to understand (since it doesn't follow the
general pattern of other IRQ functions) and prevents the possibility of
refactoring how pen state is stored.

This patch rewrites 'wacom_pl_irq' to follow the usual IRQ conventions,
including storing tool type in 'tool[0]' and implicitly tracking prox
with the 'id[0]' variable.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/wacom_wac.c