]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Tue, 25 Jan 2022 13:24:56 +0000 (13:24 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 25 Jan 2022 13:51:17 +0000 (13:51 +0000)
commita04fa9b390ff70e29446cf5513ac3493348be43f
treef315b5fe5f20fee03b4791e4a0d10ef9d79fe10a
parent6eb878c5d4080d42f70cbc4ea6bd822d56325a6c
ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function

A copy of substream pointer is stored in priv structure during
rz_ssi_dai_trigger() callback ie in SNDRV_PCM_TRIGGER_START case
and the pointer is assigned to NULL in case of SNDRV_PCM_TRIGGER_STOP.

The driver used the locks only in rz_ssi_stream_is_valid() and assigned
the local substream pointer to NULL in rz_ssi_dai_trigger() callback but
never locked it while making a local copy.

This patch adds the rz_ssi_set_substream() helper function to set the
substream pointer with locks acquired and replaces the instances of
setting the local substream pointer with the rz_ssi_set_substream()
function.

Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://lore.kernel.org/r/20220125132457.14984-3-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rz-ssi.c