]> git.baikalelectronics.ru Git - kernel.git/commit
xen-blkfront: Advertise feature-persistent as user requested
authorSeongJae Park <sj@kernel.org>
Wed, 31 Aug 2022 16:58:23 +0000 (16:58 +0000)
committerJuergen Gross <jgross@suse.com>
Fri, 2 Sep 2022 09:05:12 +0000 (11:05 +0200)
commit9f5e0fe5d05f7e8de7f39b2b10089834eb0ff787
tree4b4fbef5d7dc3b0284fa21c4a45771dfc1a22c06
parent06ba5d2e943e97bb66e75c152e87f1d2c7027a67
xen-blkfront: Advertise feature-persistent as user requested

The advertisement of the persistent grants feature (writing
'feature-persistent' to xenbus) should mean not the decision for using
the feature but only the availability of the feature.  However, commit
74a852479c68 ("xen-blkfront: add a parameter for disabling of persistent
grants") made a field of blkfront, which was a place for saving only the
negotiation result, to be used for yet another purpose: caching of the
'feature_persistent' parameter value.  As a result, the advertisement,
which should follow only the parameter value, becomes inconsistent.

This commit fixes the misuse of the semantic by making blkfront saves
the parameter value in a separate place and advertises the support based
on only the saved value.

Fixes: 74a852479c68 ("xen-blkfront: add a parameter for disabling of persistent grants")
Cc: <stable@vger.kernel.org> # 5.10.x
Suggested-by: Juergen Gross <jgross@suse.com>
Signed-off-by: SeongJae Park <sj@kernel.org>
Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20220831165824.94815-3-sj@kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/block/xen-blkfront.c