]> git.baikalelectronics.ru Git - kernel.git/commit
fbdev: fbmem: Fix the implicit type casting
authorYizhuo Zhai <yzhai003@ucr.edu>
Wed, 2 Feb 2022 23:58:08 +0000 (15:58 -0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 3 Feb 2022 12:52:03 +0000 (13:52 +0100)
commit9f28743a8e6be27af5f35502bff245e8736e0ff3
tree763ffd34b281e100ed6f19df7f495956e7d472d6
parent37560cb3013227b498675639f7294d211390764d
fbdev: fbmem: Fix the implicit type casting

In function do_fb_ioctl(), the "arg" is the type of unsigned long,
and in "case FBIOBLANK:" this argument is casted into an int before
passig to fb_blank(). In fb_blank(), the comparision
if (blank > FB_BLANK_POWERDOWN) would be bypass if the original
"arg" is a large number, which is possible because it comes from
the user input. Fix this by adding the check before the function
call.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Signed-off-by: Yizhuo Zhai <yzhai003@ucr.edu>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220202235811.1621017-1-yzhai003@ucr.edu
drivers/video/fbdev/core/fbmem.c