]> git.baikalelectronics.ru Git - kernel.git/commit
coccinnelle: Remove ptr_ret script
authorMaxime Ripard <maxime@cerno.tech>
Tue, 15 Dec 2020 12:24:59 +0000 (13:24 +0100)
committerJulia Lawall <Julia.Lawall@inria.fr>
Tue, 15 Dec 2020 19:55:19 +0000 (20:55 +0100)
commit9f16f02ae69452cb7eb20606e9de3b41fc42020d
tree9dcb657ee1e09cef8e7baa174bf29ee13418e4c9
parent5b5df5881375d0a35936e3a60b6a4ccddf6f1389
coccinnelle: Remove ptr_ret script

The ptr_ret script script addresses a number of situations where we end up
testing an error pointer, and if it's an error returning it, or return 0
otherwise to transform it into a PTR_ERR_OR_ZERO call.

So it will convert a block like this:

if (IS_ERR(err))
    return PTR_ERR(err);

return 0;

into

return PTR_ERR_OR_ZERO(err);

While this is technically correct, it has a number of drawbacks. First, it
merges the error and success path, which will make it harder for a reviewer
or reader to grasp.

It's also more difficult to extend if we were to add some code between the
error check and the function return, making the author essentially revert
that patch before adding new lines, while it would have been a trivial
addition otherwise for the rewiever.

Therefore, since that script is only about cosmetic in the first place,
let's remove it since it's not worth it.

Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Julia Lawall <julia.lawall@inria.fr>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
scripts/coccinelle/api/ptr_ret.cocci [deleted file]