]> git.baikalelectronics.ru Git - kernel.git/commit
net: lan966x: Fix return type of lan966x_port_xmit
authorNathan Huckleberry <nhuck@google.com>
Thu, 29 Sep 2022 18:27:03 +0000 (11:27 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 3 Oct 2022 23:40:16 +0000 (16:40 -0700)
commit9e547fa43f610f3907ee6a726c5730fa2af05c8e
treeb67e7c5285b9fd3bae981b203027e9936046c07c
parent53c509730dec7b78c5415d9e74ffd9a7f2040a0a
net: lan966x: Fix return type of lan966x_port_xmit

The ndo_start_xmit field in net_device_ops is expected to be of type
netdev_tx_t (*ndo_start_xmit)(struct sk_buff *skb, struct net_device *dev).

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of lan966x_port_xmit should be changed from int to
netdev_tx_t.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20220929182704.64438-1-nhuck@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/lan966x/lan966x_main.c