]> git.baikalelectronics.ru Git - kernel.git/commit
macintosh/adb-iop: Use big-endian autopoll mask
authorFinn Thain <fthain@telegraphics.com.au>
Mon, 18 Jan 2021 06:19:40 +0000 (17:19 +1100)
committerGeert Uytterhoeven <geert@linux-m68k.org>
Mon, 25 Jan 2021 12:23:38 +0000 (13:23 +0100)
commit9d63dd674fa7d60e5b00137f1265eb74dbb979f5
treecd9493bf6682e9259e7e465d6594445d05c7ce9c
parentb2b2c012f358ca8b7dad2726e29508a2a0829ef4
macintosh/adb-iop: Use big-endian autopoll mask

As usual, the available documentation is inadequate and leaves endianness
unspecified for message data. However, testing shows that this patch does
improve correctness. The mistake should have been detected earlier but it
was obscured by other bugs. In testing, this patch reinstated pre-v5.9
behaviour. The old driver bugs remain and ADB input devices may stop
working. But that appears to be unrelated.

Cc: Joshua Thompson <funaho@jurai.org>
Fixes: c23662683c2c ("macintosh/adb-iop: Implement SRQ autopolling")
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/r/20210125074524.3027452-1-geert@linux-m68k.org
drivers/macintosh/adb-iop.c