]> git.baikalelectronics.ru Git - kernel.git/commit
bpf, sockmap: fix bpf_tcp_sendmsg sock error handling
authorDaniel Borkmann <daniel@iogearbox.net>
Wed, 8 Aug 2018 17:23:13 +0000 (19:23 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 8 Aug 2018 19:06:17 +0000 (12:06 -0700)
commit9ce1d5c7772f708e0a789157bb3c3aead9f109b5
tree519bc8a547f5550b747006fefc61f0c120196164
parent253ef8d7664d4cdc227971d2bb5fdcc8be6e94f8
bpf, sockmap: fix bpf_tcp_sendmsg sock error handling

While working on bpf_tcp_sendmsg() code, I noticed that when a
sk->sk_err is set we error out with err = sk->sk_err. However
this is problematic since sk->sk_err is a positive error value
and therefore we will neither go into sk_stream_error() nor will
we report an error back to user space. I had this case with EPIPE
and user space was thinking sendmsg() succeeded since EPIPE is
a positive value, thinking we submitted 32 bytes. Fix it by
negating the sk->sk_err value.

Fixes: c88bd5e53ee4 ("bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/sockmap.c