]> git.baikalelectronics.ru Git - kernel.git/commit
net: prevent user from passing illegal stab size
author王贇 <yun.wang@linux.alibaba.com>
Fri, 24 Sep 2021 02:35:58 +0000 (10:35 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 26 Sep 2021 10:09:07 +0000 (11:09 +0100)
commit9cac5952c932763870846e4296429481f8440d5b
tree6a5e9c6f1cef6e942f20060db4b193ed3006a0d0
parented79ed9989711156d8a853508907eee39a897abe
net: prevent user from passing illegal stab size

We observed below report when playing with netlink sock:

  UBSAN: shift-out-of-bounds in net/sched/sch_api.c:580:10
  shift exponent 249 is too large for 32-bit type
  CPU: 0 PID: 685 Comm: a.out Not tainted
  Call Trace:
   dump_stack_lvl+0x8d/0xcf
   ubsan_epilogue+0xa/0x4e
   __ubsan_handle_shift_out_of_bounds+0x161/0x182
   __qdisc_calculate_pkt_len+0xf0/0x190
   __dev_queue_xmit+0x2ed/0x15b0

it seems like kernel won't check the stab log value passing from
user, and will use the insane value later to calculate pkt_len.

This patch just add a check on the size/cell_log to avoid insane
calculation.

Reported-by: Abaci <abaci@linux.alibaba.com>
Signed-off-by: Michael Wang <yun.wang@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/pkt_sched.h
net/sched/sch_api.c