]> git.baikalelectronics.ru Git - kernel.git/commit
ceph: hold extra reference to r_parent over life of request
authorJeff Layton <jlayton@kernel.org>
Wed, 3 Apr 2019 17:16:01 +0000 (13:16 -0400)
committerIlya Dryomov <idryomov@gmail.com>
Tue, 21 Jan 2020 18:02:37 +0000 (19:02 +0100)
commit9c1c2b35f1d94de8325344c2777d7ee67492db3b
tree705fb102b224f7e6685a59945726ed02124479fa
parentdef9d2780727cec3313ed3522d0123158d87224d
ceph: hold extra reference to r_parent over life of request

Currently, we just assume that it will stick around by virtue of the
submitter's reference, but later patches will allow the syscall to
return early and we can't rely on that reference at that point.

While I'm not aware of any reports of it, Xiubo pointed out that this
may fix a use-after-free.  If the wait for a reply times out or is
canceled via signal, and then the reply comes in after the syscall
returns, the client can end up trying to access r_parent without a
reference.

Take an extra reference to the inode when setting r_parent and release
it when releasing the request.

Cc: stable@vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
fs/ceph/mds_client.c