]> git.baikalelectronics.ru Git - kernel.git/commit
thermal: rockchip: fix a impossible condition caused by the warning
authorCaesar Wang <wxt@rock-chips.com>
Mon, 15 Feb 2016 07:33:28 +0000 (15:33 +0800)
committerEduardo Valentin <edubezval@gmail.com>
Tue, 1 Mar 2016 05:00:52 +0000 (21:00 -0800)
commit9bf453d94b1ef06007c416eba4d504d737493c9a
tree4dbedd55d08fde2c504cbd4e8dba36ca33d812e9
parentf8a99dc23ee72194787fe9490e8f23b768742711
thermal: rockchip: fix a impossible condition caused by the warning

As the Dan report the smatch check the thermal driver warning:
drivers/thermal/rockchip_thermal.c:551 rockchip_configure_from_dt()
warn: impossible condition '(thermal->tshut_temp > ((~0 >> 1))) =>
(s32min-s32max > s32max)'

Although The shut_temp read from DT is u32,the temperature is currently
represented as int not long in the thermal driver.
Let's change to make shut_temp instead of the thermal->tshut_temp for
the condition.

Fixes: commit cf848fd5a489
("thermal: rockchip: consistently use int for temperatures")

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/rockchip_thermal.c