]> git.baikalelectronics.ru Git - kernel.git/commit
i40e: comment that udp_port must be in host byte order
authorJacob Keller <jacob.e.keller@intel.com>
Wed, 7 Jun 2017 09:43:04 +0000 (05:43 -0400)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 21 Jun 2017 01:17:10 +0000 (18:17 -0700)
commit9b74b91527836135c8ded431b2c884c79a2bc5e1
tree268a22226b6b4a803a36c96650d4c09df6458095
parenta8a78bcae7100f00d11f296cb9d2679d45e621a4
i40e: comment that udp_port must be in host byte order

The firmware expects the port number passed when setting up
the UDP tunnel configuration to be in Little Endian format.
The i40e_aq_add_udp_tunnel command byte swaps the value from
host order to Little Endian.

Since commit 0add1eb6a5d7 ("i40e: send correct port number to
AdminQ when enabling UDP tunnels") we've correctly
sent the value in host order.

Let's also add a comment to the function explaining that it must
be in host order, as the port numbers are commonly stored as Big
Endian values.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40e/i40e_common.c