]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx4_core: clean up srq_res_start_move_to()
authorPaul Bolle <pebolle@tiscali.nl>
Tue, 14 Jan 2014 19:46:52 +0000 (20:46 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 17 Jan 2014 00:04:47 +0000 (16:04 -0800)
commit9a5a8655a1494bf2e4d77a0768a317d84773d19f
tree8a270285f6bd47a1296244ea5ed59e4bd3a46c76
parent91950c9f5db7065c2c2cdd2457949b8659647dc1
net/mlx4_core: clean up srq_res_start_move_to()

Building resource_tracker.o triggers a GCC warning:
    drivers/net/ethernet/mellanox/mlx4/resource_tracker.c: In function 'mlx4_HW2SW_SRQ_wrapper':
    drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:3202:17: warning: 'srq' may be used uninitialized in this function [-Wmaybe-uninitialized]
      atomic_dec(&srq->mtt->ref_count);
                     ^

This is a false positive. But a cleanup of srq_res_start_move_to() can
help GCC here. The code currently uses a switch statement where a plain
if/else would do, since only two of the switch's four cases can ever
occur. Dropping that switch makes the warning go away.

While we're at it, add some missing braces, and convert state to the
correct type.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c