]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: revert "xfs: fix rmap key and record comparison functions"
authorDarrick J. Wong <darrick.wong@oracle.com>
Thu, 19 Nov 2020 23:17:50 +0000 (15:17 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 19 Nov 2020 23:17:50 +0000 (15:17 -0800)
commit99706d7f6900e2aa845de06f78ae6de42dfc800c
tree300ec60cd9ad8fbf93fda120d3fb3e5b10b1e43e
parentf6568fa9781aadc62b210e7e0dd4f577273bd330
xfs: revert "xfs: fix rmap key and record comparison functions"

This reverts commit a6bdb20b2af755a127b11ca69356e45ac3da22c5.

Your maintainer committed a major braino in the rmap code by adding the
attr fork, bmbt, and unwritten extent usage bits into rmap record key
comparisons.  While XFS uses the usage bits *in the rmap records* for
cross-referencing metadata in xfs_scrub and xfs_repair, it only needs
the owner and offset information to distinguish between reverse mappings
of the same physical extent into the data fork of a file at multiple
offsets.  The other bits are not important for key comparisons for index
lookups, and never have been.

Eric Sandeen reports that this causes regressions in generic/299, so
undo this patch before it does more damage.

Reported-by: Eric Sandeen <sandeen@sandeen.net>
Fixes: a6bdb20b2af7 ("xfs: fix rmap key and record comparison functions")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
fs/xfs/libxfs/xfs_rmap_btree.c