]> git.baikalelectronics.ru Git - kernel.git/commit
geneve: do not use RT_TOS for IPv6 flowlabel
authorMatthias May <matthias.may@westermo.com>
Fri, 5 Aug 2022 19:19:03 +0000 (21:19 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 Aug 2022 05:19:20 +0000 (22:19 -0700)
commit99470e99d939716d39428acad37308fd5169a300
tree9db12cb04e419e2180faba6e27b09e8328d6b254
parent289f831ac5ee4c5d22c1c4745b1c6d5a2fa95f05
geneve: do not use RT_TOS for IPv6 flowlabel

According to Guillaume Nault RT_TOS should never be used for IPv6.

Quote:
RT_TOS() is an old macro used to interprete IPv4 TOS as described in
the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4
code, although, given the current state of the code, most of the
existing calls have no consequence.

But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS"
field to be interpreted the RFC 1349 way. There's no historical
compatibility to worry about.

Fixes: 3c9229807100 ("geneve: handle ipv6 priority like ipv4 tos")
Acked-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Matthias May <matthias.may@westermo.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/geneve.c