]> git.baikalelectronics.ru Git - kernel.git/commit
slab: Fix off by one in object max number tests.
authorDavid Miller <davem@davemloft.net>
Mon, 5 May 2014 20:20:04 +0000 (16:20 -0400)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 6 May 2014 03:38:49 +0000 (20:38 -0700)
commit98e1defdb171777181c26fdae433e42e4aaad0f2
treeb317c985e9b3b741ef1c54a420172ea692a297cc
parente64a1e4fa2fc866629b478d4ad403be69c9a87a1
slab: Fix off by one in object max number tests.

If freelist_idx_t is a byte, SLAB_OBJ_MAX_NUM should be 255 not 256, and
likewise if freelist_idx_t is a short, then it should be 65535 not
65536.

This was leading to all kinds of random crashes on sparc64 where
PAGE_SIZE is 8192.  One problem shown was that if spinlock debugging was
enabled, we'd get deadlocks in copy_pte_range() or do_wp_page() with the
same cpu already holding a lock it shouldn't hold, or the lock belonging
to a completely unrelated process.

Fixes: fdb7a514c35f ("slab: introduce byte sized index for the freelist of a slab")
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/slab.c